search

Jopp-gh / Obsidian-Dune84

Obsidian theme
GNU General Public License v2.0
29 stars 1 forks source link

Fix Default Color Schemes in Light & Dark Mode #5

Closed Bluemoondragon07 closed 1 year ago

Bluemoondragon07 commented 1 year ago

Hi! I love this theme, it's very beautiful!

One thing I noticed is that upon installation, the colors are simple desaturated Obsidian values by default. That is because the theme relies on CSS classes for its colors, so one needs to use Style Settings to toggle those CSS classes before the colors show properly.

These changes make it so that by default, even without these Style Settings classes, the colors match the theme. So when first installed, without these classes, the colors work as intended, but when a different class is selected from Style Settings it will still work as usual.

Also, thanks for making this theme! Keep up the great work.

Jopp-gh commented 1 year ago

Hi there, Just now saw your comment and I'm glad you like my theme. Thing is , this is my 3rd version of Dune, but my first public release so I'm pretty happy and curious how people may receive this project . I picked some snippets but more to see how others solve the same problems . So it was a solitary experience, now i feel a bit strange to see people's first reactions . 😅

I agree with you , yes i tried to set up a default color scheme too but i didnt spent much study for it , bc now , with the public release ,i got many small fires to put out.

Im very glad if users enjoy my theme and encourage me with bugs and feature requests, however i'd like to add collaborators only after Dunes first public release. Most of the time i didn't ask much from others although i tried to get into some nice conversion , so i want to go this last steps to the public release alone too. I hope this doesn't sadden you 😅

Bluemoondragon07 commented 1 year ago

Totally understand. 3 versions of a theme is really impressive--I can tell you worked really hard on this. Congrats on getting your theme added to the community collection 👍🏽!

Jopp-gh commented 1 year ago

Thanks for your kind words! right now my theme is kind of a "rolling release" with bug fixes mostly and some features added. Dont miss my latest updates!

some short history: My first version looked pretty good, this is 2 years ago now. After Obsidian v1 i had to refactor my original code, this was version 2, now version 3 added support to Obsidian on smartphones. I am wondering myself how much i improved lately and enjoy myself. Finally i decided, lets share with others… maybe sb appreciates too