Jopyth / MMM-Remote-Control

Magic Mirror Module to shutdown or configure your mirror
MIT License
489 stars 146 forks source link

No consideration of the module number #229

Closed JVF2 closed 3 years ago

JVF2 commented 3 years ago

Hi guys,

if I had several modules with the same name, inserting the module number worked until now. For example: "http://192.XXX.XXX.XX:8080/remote?action=SHOW&module=module_10_MMM-SmartWebDisplay"

Currently, regardless of the number, all modules named "MMM-SmartWebDisplay" are shown or hidden.

What am I doing wrong?

Many thanks in advance.

ezeholz commented 3 years ago

Hey! Do you try using the api for that? Are you using the last version of the Remote Control?

JVF2 commented 3 years ago

Hello,

thank you for the quick response.

What do you mean, do I use the API? Unfortunately I am not an expert. :-( So far my homee sent the exemplary link. That worked well.

Yes, I have installed the current version.

ezeholz commented 3 years ago

In the last version I change a few paths, and maybe broke the remote endpoint. I'll check it. In the meantime, you should use the api, that's the new implementation of the 2.0.0 To use it, you can go to http://192.xxx.xxx.xxx:8080/api/docs There it's every single endpoint you can use.

I believe the one you're looking it's http://192.xxx.xxx.xxx:8080/api/module/module_10_MMM-SmartWebDisplay/show

Let me know if that works. Cheers ;D

Update: I found the issue, so I'll work on that now. :D

ezeholz commented 3 years ago

Let me know if that commit let you hide only the module you want.

JVF2 commented 3 years ago

The commit works. Thank you very much!

ezeholz commented 3 years ago

Thank you for letting me know! Fixing it in the master branch now.