search

Jopyth / MMM-Remote-Control

Magic Mirror Module to shutdown or configure your mirror
MIT License
497 stars 147 forks source link

QR code #290

Open abersnaze opened 1 year ago

abersnaze commented 1 year ago

Description

I think it would be easier to use if the module put a QR code of the URL on the screen.

Changelog

No response

Requirements

I was looking around the code and i found the getDom function that generates the URL. Change it to use https://www.npmjs.com/package/qrcode on the wrapper element.

Additional info

No response

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

RomainLG commented 8 months ago

@Jopyth Hi there! I don't think this was considered enough before closing, this feature would be so easier than typing an IP adress.

If someone wants to tackle this it would be awesome! Maybe @nischi from mmm-news-qr can help?

ezeholz commented 8 months ago

I don't think it's worth to add just another dependency to our code just for the purpose of this issue.

We could use the multiple services that generates QR codes without actually adding another dependency.

Saying that, I'm under a rough time with my schedules, so I can't really develop nor test complex solutions at the time. But I'll be glad if you guys come up with a PR of this.

RomainLG commented 8 months ago

With an api like goqr.me/api? This just works : https://api.qrserver.com/v1/create-qr-code/?size=150x150&data="http://192.168.0.119:8080"

But then is that wgat you mean by dependancy? If that site changes it won't work anymore

abersnaze commented 8 months ago

the mmm-news-qr module has a minified (19KB) qrcode generator bundled to avoid external deps.

https://github.com/nischi/MMM-News-QR/blob/master/qrcode.min.js

ezeholz commented 8 months ago

That could be an option. I would be glad to get some info about it, just to be sure that it's safe. That way we're not using any external dependencies, making the code maintainable.

nischi commented 8 months ago

hi guys.

Nice to hear that my feature is used :) Should not be a big deal to implement a qr code. I'm also a little bit busy at the moment, but sounds like fun, try to find some time to create a PR.