search

Jopyth / MMM-Remote-Control

Magic Mirror Module to shutdown or configure your mirror
MIT License
498 stars 149 forks source link

Remote Control REST API improvements #292

Open Anonym-tsk opened 1 year ago

Anonym-tsk commented 1 year ago

Bug Fix

Fixes #291

Steps to reproduce

Additional info

github-actions[bot] commented 1 year ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Da3o55 commented 1 month ago

Hi boys and girls, I give you my experience. Since long time, REST API no more work. Few days ago, i made a full update of my MagciMirror, OS, and all modules. Everything is ok ... but REST API still not working.

I used MMM-Carousel and normaly write with the possibilité to use REST API. This module use "REGISTER_API" method. As it don't work, i tried to modifed an other module and upgrade it to be REST API compatible. Any way it don't work. I found this pull request, so tried to apply the proposed changes on my environment and ... miracle it's work. Does this pull request have chance to be merge a day ?