search

JoramSoch / MACS

MACS – a new SPM toolbox for model assessment, comparison and selection
GNU General Public License v3.0
23 stars 6 forks source link

Octave failure with goodness of fit module #15

Open Remi-Gau opened 1 year ago

Remi-Gau commented 1 year ago

Found when running tests in CI.

It seems that the goodness of fit computation runs fine and the nifti image for it is generated but the failure is due to the part that is trying to visualize the results in the GUI.

A way around it would be to skip the visualization in Octave: can open a PR if you are interested.

Copied from https://github.com/cpp-lln-lab/bidspm/issues/1141

warning: Unable to open display.
warning: called from
    spm at line 656 column 9
    spm at line 577 column 4
    spm at line 610 column 5
    MA_inspect_GoF at line 572 column 8
    MA_inspect_GoF at line 687 column 5
    spm_XYZreg at line 513 column 5
    spm_XYZreg at line 562 column 1
    MA_inspect_GoF at line 355 column 5
    MA_inspect_GoF at line 196 column 10
    run_module at line 66 column 1
    cfg_run_cm at line 26 column 5
    local_runcj at line 1717 column 20
    cfg_util at line 972 column 27
    fill_run_job at line 469 column 5
    spm_jobman at line 247 column 13
    saveAndRunWorkflow at line 41 column 14
    bidsFFX at line 128 column 12
    cliStats>runEstimate at line 110 column 7
    cliStats at line 82 column 9
    bidspm>executeAction at line 86 column 7
    bidspm at line 26 column 16
    moae_fmriprep at line 108 column 1
    run at line 93 column 5
    system_tests_fmriprep at line 12 column 1
    run at line 93 column 5

warning: Invalid registry handle
warning: called from
    spm_XYZreg at line 578 column 21
    register at line 757 column 5
    spm_orthviews at line 422 column 9
    spm_sections at line 38 column 20
    MA_inspect_GoF at line 201 column 5
    run_module at line 66 column 1
    cfg_run_cm at line 26 column 5
    local_runcj at line 1717 column 20
    cfg_util at line 972 column 27
    fill_run_job at line 469 column 5
    spm_jobman at line 247 column 13
    saveAndRunWorkflow at line 41 column 14
    bidsFFX at line 128 column 12
    cliStats>runEstimate at line 110 column 7
    cliStats at line 82 column 9
    bidspm>executeAction at line 86 column 7
    bidspm at line 26 column 16
    moae_fmriprep at line 108 column 1
    run at line 93 column 5
    system_tests_fmriprep at line 12 column 1
    run at line 93 column 5

17-Sep-2023 03:10:12 - Failed  'MA: inspect goodness of fit'
Invalid object handle
In file "/home/runner/work/bidspm/bidspm/spm12/spm_XYZreg.m" (v7388), function "spm_XYZreg" at line 453.
In file "/home/runner/work/bidspm/bidspm/spm12/spm_orthviews.m" (v7376), function "register" at line 761.
In file "/home/runner/work/bidspm/bidspm/spm12/spm_orthviews.m" (v7376), function "spm_orthviews" at line 422.
In file "/home/runner/work/bidspm/bidspm/spm12/spm_sections.m" (v4199), function "spm_sections" at line 38.
In file "/home/runner/work/bidspm/bidspm/spm12/toolbox/MACS/MA_inspect_GoF.m" (???), function "MA_inspect_GoF" at line 201.
In file "/home/runner/work/bidspm/bidspm/spm12/toolbox/MACS/batch_MA_inspect_GoF.m" (???), function "run_module" at line 66.
JoramSoch commented 1 year ago

Dear @Remi-Gau,

A way around it would be to skip the visualization in Octave: can open a PR if you are interested.

That would be great, since I do not immediately see how or whether I can repair Octave problems with a very specific SPM visualization routine (which I borrowed here) by only changing the toolbox code.

Cheers, Joram.

PS: Sorry for not replying to Issue #8 so far. I've really been busy and would just need to start looking at the problem.

Remi-Gau commented 1 year ago

Will try to open a pull request. Bandwidth permitting.

Not sure if I can write a simple test with automation for it to avoid regressions (without doing too much set up and or refactoring).