fix missing SPM.swd field when running cvLME on unestimated models

JoramSoch / MACS

MACS – a new SPM toolbox for model assessment, comparison and selection

GNU General Public License v3.0

23 stars 6 forks source link

fix missing SPM.swd field when running cvLME on unestimated models #4

Closed Remi-Gau closed 4 years ago

Remi-Gau commented 5 years ago

this fix will update the content of SPM structure by adding the missing field when running the batch
- I suspect that MA_cvLME_multi.m will still throw an error if it receives an unestimated SPM as argument.

Remi-Gau commented 5 years ago

This is not quite ideal but it will let the batch work and partially fix issue #3.

JoramSoch commented 4 years ago

Sorry @Remi-Gau, I've totally missed that there have been issues and pull requests on this repository for almost half a year. I hope to address this issue by the end of the week.

Remi-Gau commented 4 years ago

no worries I had put this one on the back burner anyway

JoramSoch commented 4 years ago

Thanks for providing the bugfix! I have now extended this correction to other functions where it also had to be applied. As you say, this will not work, if "MA_cvLME_single/multi/other.m" are called from the command line with a non-estimated model. But at least it is a solution for the batch interface.

Remi-Gau commented 4 years ago

Had not realized that this would be an issue in other cases. Glad I could help. :+1: