Firmware tests for a design collaboration between Cornell University’s K. Lisa Yang Center for Conservation Bioacoustics and Analog Device’s Central Applications Group using ADI’s microcontroller and A2D products to power Cornell’s second generation SWIFT autonomous recording units hardware/firmware platform
Apache License 2.0
0
stars
0
forks
source link
Filter plot test argument choices includes invalid sample rates #6
See the line below. The legal sample rates are now [24, 48, 96, and 192]. We removed the 16 and 32kHz cases when we switched to all IIR filters, which perform better when all decimation ratios have only divide-by-2's in them. 384kHz is not included as a valid choice for the filter tests because we don't do any filtering for this special case.
To fix, simply remove 16 and 32 from the list of choices. While you're at it fix the README as well.
JordanAceto
commented
1 week ago
See the line below. The legal sample rates are now [24, 48, 96, and 192]. We removed the 16 and 32kHz cases when we switched to all IIR filters, which perform better when all decimation ratios have only divide-by-2's in them. 384kHz is not included as a valid choice for the filter tests because we don't do any filtering for this special case.
To fix, simply remove 16 and 32 from the list of choices. While you're at it fix the README as well.
https://github.com/JordanAceto/Magpie/blob/710b1f07e04fe3cf03bed5014f1b3d6927cb5d44/main_microcontroller_firmware/test/integration_tests/filter_tests/filter_test_main.py#L20