Minor MLP typo - Githubissues

JordanAsh / badge

An implementation of the BADGE batch active learning algorithm.

197 stars 32 forks source link

Minor MLP typo #13

Closed gregcanal closed 1 year ago

gregcanal commented 1 year ago

Hey Jordan, lm2 isn't actually used in this MLP implementation: https://github.com/JordanAsh/badge/blob/b1706005795fd150743b75bf0cd206137d806bb7/run.py#L191

This seems like a minor typo since the current functionality is consistent with the paper (two-layer perceptron: self.lm1 + self.linear), but figured I'd point it out.

Thanks

JordanAsh commented 1 year ago

good catch!