search

JordanKwua / pe

0 stars 0 forks source link

Cannot add patients names with three space-separated words #2

Open JordanKwua opened 2 years ago

JordanKwua commented 2 years ago

Could be considered as incomplete as patients can have names with three space separation such as 'Tan Ah Beng' and they can only be added as Tan AhBeng.

nus-se-bot commented 2 years ago

Team's Response

Specified that the patient name can only be two, including first and last name on government ID without any middle name

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I believe I was not clear enough in writing this issue, I understand where the team is coming from to not have the middle name. But a significant amount of people especially the Chinese do not have a so called first and last name, but instead they have a first name(usually the surname) and a given name which follows after.

If the person has an english name then its great, they can have their surname followed by their english name e.g. John Tan Jun Jie can be inserted as John Tan. What if the person doesn't have an english name e.g. Lee Hsien Loong, Heng Swee Keat, would their names be entered as Lee HsienLoong or Heng SweeKeat which makes the input valid but doesn't make sense practically? If not they would become Lee Hsien or Lee Loong which doesn't make sense as well. It might seem a bit unreasonable but from my point of view its a practical issue.