search

JordanMarr / ReactiveElmish.Avalonia

Static Avalonia views for Elmish programs
Other
92 stars 8 forks source link

place IsAutoUpdating in model #20

Closed houstonhaynes closed 1 year ago

houstonhaynes commented 1 year ago

Interim improvement where IsUpdating is managed within the model and the conditional that triggers the loop to update the observable series is in the subscription's list comprehension.

JordanMarr commented 1 year ago

I made a small improvement: https://github.com/JordanMarr/Elmish.Avalonia/commit/21a3a64e23987e421869ffde9fc6c4a3ab1146cc

houstonhaynes commented 1 year ago

I tried a few tacks with that and couldn't quite turn the corner to make it all hook up. Thanks!

JordanMarr commented 1 year ago

I think the key was to get rid of the click/Command property on the ToggleButton and instead rely only on the two-way binding to the IsChecked property.