JordanMartinez / learn-halogen

Learn purescript-halogen using a bottom-up apporach via this "clone-and-play" repository
188 stars 28 forks source link

`--no-minify` is not supported by `serve` action of `parcel` #46

Closed vlatkoB closed 5 years ago

vlatkoB commented 5 years ago

In the Learn Halogen there is a compilation instruction: parcel serve assets/path/to/corresponding/HTML_File.html -o HTML_File--parcelified.html --open --no-minify However, parcel serve does not support --no-minify, only parcel build suports it.

JordanMartinez commented 5 years ago

I've fixed that in 9f3fcbd3018237a07040d2a021c92dcefb4491ca

It'll be included in next release.

JordanMartinez commented 5 years ago

Also, in this situation, these instructions are illustrative. The real ones are found in later files.

vlatkoB commented 5 years ago

This is (still) my first read and when I got to that first page, I immediately wanted to try the first example. That is how I stumbled upon this issue.

JordanMartinez commented 5 years ago

Ahh, that makes sense.

Even so, I'm glad you brought the issue up.