search

JordanMartinez / purescript-cookbook

An unofficial Cookbook for PureScript
MIT License
198 stars 30 forks source link

Bump `easy-purescript-nix` #264

Closed pete-murphy closed 3 years ago

pete-murphy commented 3 years ago

packages.dhall specifies PureScript 0.13.8, while the easy-purescript-nix commit hash points to 0.13.6, so trying to build the project in nix-shell fails.

Before

Screen Shot 2021-01-18 at 1 36 19 AM

After

Screen Shot 2021-01-18 at 1 37 39 AM
pete-murphy commented 3 years ago

I haven't jumped on the nix train yet, but I trust this is a change for the better.

Yeah, I don't know, it seems like keeping the shell.nix up to date might be a bit of a burden if the core maintainers of this project aren't using Nix, so alternatively could just scrap the Nix stuff 🤷 . For Nix users, nix-prefetch-git https://github.com/justinwoo/easy-purescript-nix.git will get the latest rev and sha256, so this at least adds those instructions if it gets out of sync in the future. I wonder if it's something that could be automated in CI.

Also, those are some nice looking shadowed screenshots. Was wondering if that was a new GH feature, but guessing you just grabbed a bit of desktop too.

I'm on a Mac, that's just the default screenshot look when you capture a window. It is nice.

JordanMartinez commented 3 years ago

Yeah, nix is a great idea but something I just don't use right now. If we did support it, I would prefer to add a disclaimer of "use nix to build this project at your own risk; maintainers have not vetted what the nix code does" or something to that effect. If we don't do that, then dropping it entirely would be best.

JordanMartinez commented 3 years ago

I'm not sure I want to keep nix in the future, but I think this is safe to merge.