Remove unnecessary Unsafe.Coerce usage

JordanMartinez / purescript-cookbook

An unofficial Cookbook for PureScript

MIT License

198 stars 30 forks source link

Remove unnecessary Unsafe.Coerce usage #276

Closed pete-murphy closed 3 years ago

pete-murphy commented 3 years ago

Slight refactor to get rid of the homespun toDragEvent here and remove the usage of Unsafe.Coerce.coerce. I wasn't aware of React.Basic.DOM.Events.nativeEvent at the time.

pete-murphy commented 3 years ago

Hmm getting a couple of errors in CI:

🚨  /home/travis/build/JordanMartinez/purescript-cookbook/recipes/HelloLog/web/index.js: Invalid Version: undefined

and

🚨  /home/travis/build/JordanMartinez/purescript-cookbook/recipes/ButtonsHalogenHooks/web/index.js: Invalid Version: undefined

pete-murphy commented 3 years ago

Seems to be an issue with parcel-bundler, the author recommends upgrading to v2 here https://github.com/parcel-bundler/parcel/issues/5943#issuecomment-799899064, I'll see if that helps.

Edit: I went with a patch-version upgrade to v1.12.5, since it seems v2 is still in beta.