JordanMartinez / purescript-cookbook

An unofficial Cookbook for PureScript
MIT License
199 stars 30 forks source link

Bump PureScript to 0.14.3 #280

Closed pete-murphy closed 3 years ago

pete-murphy commented 3 years ago

All told, only ~17~ 14 of 80 ended up in the broken pile which doesn't seem too bad.


JordanMartinez commented 3 years ago

Thanks for working on this!

JordanMartinez commented 3 years ago

Don't worry about these ones:

Can't do anything about these ones other than get the packages added again to the package set:

pete-murphy commented 3 years ago
* Argument order was switched in [node-readline#23](https://github.com/purescript-node/purescript-node-readline/pull/23/files):

  * DiceCLI

* `FProxy` was replaced with `Proxy`

  * RunCapabilityPatternNode

* `Map`'s `Monoid` instance was dropped. Use [`SemigroupMap`](https://pursuit.purescript.org/packages/purescript-ordered-collections/2.0.1/docs/Data.Map#t:SemigroupMap) newtype to get instance again, but check the `k`'s `Monoid` instance to verify that implementation is still the same:

  * SignalTrisJs

Sounds good 👍 those seem reasonable enough to tackle in this PR

JordanMartinez commented 3 years ago

Thanks again for all this work!

pete-murphy commented 3 years ago
* [ ]  Let's change migrate from the `fromRight` partial function to `either (\_ -> unsafeCrashWith "got Left: bad parser") identity`.

I think

either (\_ -> unsafeCrashWith "got Left: bad parser") identity

is same as

fromRight' \_ -> unsafeCrashWith "got Left: bad parser"

I'm fine with either (no pun intended) but would you still prefer the former?

JordanMartinez commented 3 years ago

Oh, whoops! Yeah, let's use the fromRight' \_ -> ... version.

pete-murphy commented 3 years ago

make buildAll works with the 0.14.3 package set 👍

JordanMartinez commented 3 years ago

I'm going to use a merge commit for this PR because it touches so many different recipes.