search

JordanMartinez / purescript-cookbook

An unofficial Cookbook for PureScript
MIT License
198 stars 30 forks source link

chore: moved CapabilityPatternNode files to match modules #287

Closed neilhan closed 2 years ago

neilhan commented 2 years ago

Moved files to folder structure that matches the modules defined by each purs files. Origin recipes files:

./CapabilityPatternNode/src/Application.purs -- defined as module App.Application ./CapabilityPatternNode/src/ProductionAsync.purs -- defined as module App.Production.Async ./CapabilityPatternNode/src/Main.purs -- defined as module CapabilityPatternNode.Main ...

I am not certain whether my understanding is correct here. I am happy to learn. I am assuming modules should be put under matching file structure as this:

./CapabilityPatternNode/src/ ./CapabilityPatternNode/src/App/Production/Async.purs -- defined as module App.Production.Async ./CapabilityPatternNode/src/App/Application.purs -- defined as module App.Application ./CapabilityPatternNode/src/CapabilityPatternNode/Main.purs -- defined as module CapabilityPatternNode.Main ...

JordanMartinez commented 2 years ago

It's been quite some time since I've worked on this repo, so I'm not as familiar with it as I used to be. Could you provide more context on this issue?

neilhan commented 2 years ago

Let me update my PR message. I am learning PureScript. It is possible that this PR is completely unnecessary. Feel free to close this PR without merging.

I googled my question for a bit. It seems that Purescript does not enforce module - folder/fileName matching.

My original issue is not resolved after I moved files to match the module.

I am using VScode, Purescript IDE. When I try to follow a symble or a module that was under "App", VSCode fails with "no definition found" error. Which I suspect is caused by how this repo is organized. I don't fully understand.

BTW, I really enjoy the materials you shared. Thank you for making them available.