search

JordanMartinez / purescript-jordans-reference

Learn PureScript with this "clone and play" repository
https://jordanmartinez.github.io/purescript-jordans-reference-site/
588 stars 73 forks source link

Fixed topic 'Building This Project' #576

Closed oldfartdeveloper closed 2 years ago

oldfartdeveloper commented 2 years ago

Fixes: #575

  1. Rebuilt this capability
  2. Cleaned up the install/build/test reporting.
  3. In script spago--build-and-test.sh, changed compare operator == to = and made is a sh script instead of a bash script to upgrade to fix a MacOS Catalina syntax incompatibility.

The above changes were made so that continuous integration facility's functionality was left unchanged. The edits look more extensive than they really are in that I had to move large chunks of the shell code from one script to another.

JordanMartinez commented 2 years ago

Sorry for taking a while to get to this. Thanks for doing this!

JordanMartinez commented 2 years ago

I think CI is failing because .github/workflows/ci.yml never makes .ci/spago--build-and-test-non-ci.sh executable via chmod +x .ci/spago--build-and-test-non-ci.sh. But if that's the case, can we drop .ci/spago--build-and-test.sh and just call exit "source .ci/spago--build-and-test-non-ci.sh" directly as a step in the GH Action? And if so, then could we drop the -non-ci part of that file's name?

oldfartdeveloper commented 2 years ago

Have suggested Jordan fixes.

oldfartdeveloper commented 2 years ago

I've submitted PR #577 that has:

  1. Incorporated your suggestions.
  2. Removed some ambiguity that I found in my text in this PR.
  3. Verified that the CI runs successfully on my fork.

Hence, closing this PR so that you can concentrate on #577