JordanSantiagoYT / FNF-JS-Engine

JS Engine is basically Psych Engine but with (almost) no botplay lag and NEW features!
Apache License 2.0
41 stars 26 forks source link

still crashing when loading modded song audio files 😭 #530

Closed nxvelveteen closed 1 day ago

nxvelveteen commented 2 weeks ago

Describe your bug here. If you are modding, try testing your bug in a clean version of the engine instead. Also, if you're using an older version of JSE, please try the latest version/action build. Also, be sure to check the pinned 'JS Engine: Known Issues' issue, to check if your issue hasn't already been found!

the engine is looking in the assets folder for some odd reason even though I had the mod selected and turned on

Command Prompt/Terminal/Crash logs (if existing)

C:\Users\dropf\Dropbox\Downloads\jsengine>source/DiscordClient.hx:82: Discord Client initialized
source/InitState.hx:29: save status: BOUND(funkin,JordanSantiago/JSEngine)
source/TitleState.hx:95: checking for update
source/TitleState.hx:108: version online: 1.32.2, your version: 1.32.2
source/TitleState.hx:115: the versions match!
source/LoadingState.hx:162: Setting asset folder to shared
source/Paths.hx:84:
source/Paths.hx:88: noteskins/NOTE_assets
source/Paths.hx:708: oh no its returning null NOOOO (assets/songs/test/Voices-dad.ogg)
source/Conductor.hx:156: new BPM map BUDDY []
source/Paths.hx:708: oh no its returning null NOOOO (assets/songs/implicit-demand-for-proof/Voices-bf.ogg)
source/Paths.hx:708: oh no its returning null NOOOO (assets/songs/implicit-demand-for-proof/Voices.ogg)
source/Paths.hx:708: oh no its returning null NOOOO (assets/songs/implicit-demand-for-proof/Voices-dad.ogg)

Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible.

No response

Are you modding a build from source or with Lua?

Lua

What is your build target?

Windows

Did you edit anything in this build? If so, mention or summarize your changes.

no

If you use 1.12.0 or earlier, did you have Optimized Chart Loading turned on?

None

Did you check for any similar issues to what you're reporting? Check, then come back here. If there is a similar issue, then do not report the issue, otherwise it will be marked as a duplicate.

Yes

JordanSantiagoYT commented 2 weeks ago

did you DOUBLE CHECK that in your song's json, you didn't turn on "Has voice track"??

nxvelveteen commented 2 weeks ago

did you DOUBLE CHECK that in your song's json, you didn't turn on "Has voice track"??

my song doesn't have a json saved for it, I'm trying to load the audio so I can start charting it but I did uncheck "has voice track" in the chart editor before loading

nxvelveteen commented 2 weeks ago

idk if it helps but but the difficulties for the song are Vocals, Drums, and Piano

moxie-coder commented 2 weeks ago

idk if it helps but but the difficulties for the song are Vocals, Drums, and Piano

image

did you modify the game in anyway to add those difficulties?

nxvelveteen commented 1 week ago

idk if it helps but but the difficulties for the song are Vocals, Drums, and Piano

image

did you modify the game in anyway to add those difficulties?

I typed those difficulties into the week editor if that's what you mean, I have 0 haxe knowledge

nxvelveteen commented 1 week ago

the same thing happens in psych engine too so idk

PatoFlamejanteTV commented 3 days ago

Send your mod to me and I will help (trying) to fix, probally it's just an goofy voice glitch

PatoFlamejanteTV commented 1 day ago

wait why is that loading two songs?

assets/songs/test/Voices-dad.ogg assets/songs/implicit-demand-for-proof/Voices-bf.ogg

PatoFlamejanteTV commented 1 day ago

the same thing happens in psych engine too so idk

Ok, probably is a problem with the audio's metadata, did you have the audio? Can you send a link for testing purposes?

PatoFlamejanteTV commented 1 day ago

Closed due to author's inactivity...

nxvelveteen commented 1 day ago

Closed due to author's inactivity...

@PatoFlamejanteTV Sorry for not responding I didn't notice the reply I'll send the files in a bit

nxvelveteen commented 1 day ago

Here just have the mod folder https://www.mediafire.com/folder/1neaak179efol/FNF+x+TOP

moxie-coder commented 23 hours ago

wait why is that loading two songs?

assets/songs/test/Voices-dad.ogg assets/songs/implicit-demand-for-proof/Voices-bf.ogg

opponent vocals & bf vocals, but it’s weird it’s loading from two different songs