1.37 engine is incredibly laggy for some reason

Niko-The-Fluffy commented 3 weeks ago

Describe your bug here. If you are modding, try testing your bug in a clean version of the engine instead. Also, if you're using an older version of JSE, please try the latest version/action build. Also, be sure to check the pinned 'JS Engine: Known Issues' issue, to check if your issue hasn't already been found!

So we ported Polyverse from 1.33 to 1.37, and it worked fine until the opponent started hitting notes. It caused the engine to start lagging a lot, and it stayed like that even after leaving the song.

https://github.com/user-attachments/assets/b5aee0a3-8bdd-4280-83e6-fab995f12e89

It doesn't cause any crashes, but it makes the engine run at under 30 fps which isn't optimal for the mod at all.

Command Prompt/Terminal/Crash logs (if existing)

No response

Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible.

Simply going into a song and hitting any notes causes the lag to start.

Are you modding a build from source or with Lua?

Lua

What is your build target?

Windows

Did you edit anything in this build? If so, mention or summarize your changes.

Ported Polyverse from 1.33 to 1.37

If you use 1.12.0 or earlier, did you have Optimized Chart Loading turned on?

None

Did you check for any similar issues to what you're reporting? Check, then come back here. If there is a similar issue, then do not report the issue, otherwise it will be marked as a duplicate.

Yes

StinkTheStinker commented 2 weeks ago

check the fps limit in options
what ram do you have

Niko-The-Fluffy commented 2 weeks ago

check the fps limit in options

what ram do you have

60 fps
about 32 iirc

StinkTheStinker commented 2 weeks ago

about 32 iirc

what the fuck is iirc

moxie-coder commented 2 weeks ago

about 32 iirc

what the fuck is iirc

if I recall correctly

nate902011 commented 2 weeks ago

have the same issue except it started before it even loaded. 1.36 was not like this.

nate902011 commented 2 weeks ago

https://drive.google.com/file/d/1KqCFha3hHrD_wwMtzrXBs6ScyheBt6Au/view?usp=sharing

nate902011 commented 2 weeks ago

and then the longer you play the more it lags until it crashes (no log)/never responds or until it becomes unplayable.

JordanSantiagoYT commented 2 weeks ago

This is due to memory usage, and is not something I can fix or control.

The closest thing is the "Enable GC" option (in the Optimizations options menu)

nate902011 commented 2 weeks ago

This is due to memory usage, and is not something I can fix or control.

The closest thing is the "Enable GC" option (in the Optimizations options menu)

memory usage? back in 1.36 with the same memory usage i have now, it was working fine, and reducing it doesn't help (trust me, i've tried).

and disabling "Enable GC" doesn't help either.

the same things as described before still occur.

nate902011 commented 2 weeks ago

https://drive.google.com/file/d/1DBUJUyG2e3QtPIbQMxNpzb2MYH8e6l0A/view?usp=sharing

StinkTheStinker commented 2 weeks ago

...back in 1.36 with the same memory usage i have now, it was working fine, and reducing it doesn't hep (trust me, i've tried).

theres no other way of trying to fix this then, how much ram do you have anyway

StinkTheStinker commented 2 weeks ago

theres no other way of trying to fix this then, how much ram do you have anyway

another thing, in the gameplay options, turn on low quality, and turn off anti-aliasing. if you have not done that at least

nate902011 commented 1 week ago

theres no other way of trying to fix this then, how much ram do you have anyway

another thing, in the gameplay options, turn on low quality, and turn off anti-aliasing. if you have not done that at least

i have 8 gb of ram

enabling low quality and disabling anti-aliasing doesn't help

StinkTheStinker commented 1 week ago

open task manager and go to the performace tab of it and look at your cpu, gpu (graphics card), and ram. look at it with the game open, i think cpu gives fps or some shit

if its not the reason, then i have no clue. js will probably close it if theres 3-5 days of inactivity on this issue

Niko-The-Fluffy commented 1 week ago

open task manager and go to the performace tab of it and look at your cpu, gpu (graphics card), and ram. look at it with the game open, i think cpu gives fps or some shit

if its not the reason, then i have no clue. js will probably close it if theres 3-5 days of inactivity on this issue

I could show mine but it'd have to wait for Monday when I can get my computer that has the build on it

nate902011 commented 1 week ago

i have v1.37.1 and 1.36 downloaded at the same time and it isn't me or my setup, it's 1.37. when playing js 1.36, only a few, very minor lag spikes occur. but with 1.37.1, it lags a lot more and more aggressively. and this is also something that happens on 1.37, if you tab out for a minute or two, you'll find it's fps at an unplayable 13-20. and the more you tab out, the worse it gets, until boom, it freezes up and never loads.

nate902011 commented 1 week ago

maybe they might've just messed up the code somehow and we might have to wait for 1.38 for this to get fixed.

moxie-coder commented 1 week ago

I didn’t do anything really, but I could find a way to fix the lag maybe

On Sat, Nov 9, 2024 at 3:33 AM nate902011 @.***> wrote:

maybe they might've just messed up the code somehow and we might have to wait for 1.38 for this to get fixed.

— Reply to this email directly, view it on GitHub https://github.com/JordanSantiagoYT/FNF-JS-Engine/issues/707#issuecomment-2466118533, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5VHQKRTT4UAVYYHPBK4GYDZ7XCELAVCNFSM6AAAAABRAH4HEWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRWGEYTQNJTGM . You are receiving this because you commented.Message ID: @.***>