JordanSantiagoYT / FNF-PsychEngine-NoBotplayLag

Psych Engine but with no botplay lag and some NEW features!
Apache License 2.0
34 stars 19 forks source link

Renders don't show up in the gameRenders folder (Ubuntu 24.04 LTS x64) #408

Open u0-a63 opened 6 days ago

u0-a63 commented 6 days ago

Describe your bug here. Mind you, if you are modding, please try testing your bug in a clean version of the engine instead, this ensures the bug is actually caused by the engine itself. Also, if you're using an older version of JSE, please try the latest action build in the Actions tab or the latest release build. The issue has probably been fixed since that version. Oh yeah, and also be sure to check the pinned 'JS Engine: Known Issues' issue, to double check if your issue hasn't already been found!

When I use Rendering Mode, NOTHING appears in the renders folder. Yes, I do have the ffmpeg package installed. Do I have to do something else to get this to work?

Command Prompt/Terminal/Crash logs (if existing)

source/TitleState.hx:143: checking for update
source/TitleState.hx:156: version online: 1.27.2, your version: 1.27.2
source/TitleState.hx:163: the versions match!
source/LoadingState.hx:162: Setting asset folder to shared
source/FreeplayState.hx:610: talking
source/FreeplayState.hx:624: CURRENT WEEK: funnyweek
source/LoadingState.hx:162: Setting asset folder to shared
source/PlayState.hx:7824: "FFmpeg.exe" not found! (Is it in the same folder as the JS Engine exe?)
source/PlayState.hx:2070: Anim speed: 1
source/Conductor.hx:156: new BPM map BUDDY [{ stepTime => 0, stepCrochet => 21.4285714285714, bpm => 700, songTime => 0 }]
source/Paths.hx:121: NOTE_assets
source/FunkinLua.hx:2922: initializing haxe interp for: mods/funnysongs/scripts/dyed.lua
source/FunkinLua.hx:114: lua file loaded succesfully:mods/funnysongs/scripts/dyed.lua
source/PlayState.hx:1394: Loading chart...
source/Paths.hx:725: oh no its returning null NOOOO (assets/songs/talking/Voices.ogg)
source/PlayState.hx:3412: Done! 1537 notes were loaded in 0.022446870803833 seconds.
source/PlayState.hx:5424: cached gold ratings
source/PlayState.hx:2070: Anim speed: 1
source/PlayState.hx:5329: WENT BACK TO FREEPLAY??

Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible.

Try to render a song on the latest Ubuntu version (24.04 LTS as of writing this issue), it doesn't work even if you install the ffmpeg package.

Are you modding a build from source or with Lua?

Lua

What is your build target?

Linux

Did you edit anything in this build? If so, mention or summarize your changes.

No, I only added a mod.

If you use 1.12.0 or earlier, did you have Optimized Chart Loading turned on?

None

Did you check for any similar issues to what you're reporting? Check, then come back here. If there is a similar issue, then do not report the issue, otherwise it will be marked as a duplicate.

Yes

JordanSantiagoYT commented 6 days ago

...

it says "Is ffmpeg.exe in the same folder as the JS Engine exe?"

u0-a63 commented 3 days ago

Yes, I know, but Ubuntu doesn't use .exe files!

u0-a63 commented 3 days ago

Also, stupid thing to ask, but, can you fix the camera shaking when you run the game at 30FPS? Watch the video file I attached (the pixeldrain link) and you'll see what I mean. https://pixeldrain.com/u/empxj4qi

Stefan2008Git commented 2 days ago

...

it says "Is ffmpeg.exe in the same folder as the JS Engine exe?"

Bruh, blud doesn't know about Linux execution files 💀

JordanSantiagoYT commented 2 days ago

Yes, I know, but Ubuntu doesn't use .exe files!

my bad, i forgot to make the trace thing trace only "'ffmpeg not found!" instead of "ffmpeg.exe not found!"

did you put the ffmpeg file in the same location as JSEngine?

JordanSantiagoYT commented 2 days ago

Also, stupid thing to ask, but, can you fix the camera shaking when you run the game at 30FPS? Watch the video file I attached (the pixeldrain link) and you'll see what I mean. https://pixeldrain.com/u/empxj4qi

i am aware of this issue, but there's nothing i can do to fix it because the last time i tried there were issues with the camera following the players too slowly.

u0-a63 commented 1 day ago

Even on Windows, there's a problem with Rendering Mode. There's no sound in the finished .mp4 file. Can you fix this?

Stefan2008Git commented 1 day ago

Even on Windows, there's a problem with Rendering Mode. There's no sound in the finished .mp4 file. Can you fix this?

Rendering Mode should be removed from game when you can literally use OBS for that. I don't care how much it will give a huge CPU usage and lag, just configure the settings and that's all

JordanSantiagoYT commented 1 day ago

Even on Windows, there's a problem with Rendering Mode. There's no sound in the finished .mp4 file. Can you fix this?

..you're supposed to use a video editor to edit it in

JordanSantiagoYT commented 1 day ago

Rendering Mode should be removed from game when you can literally use OBS for that. I don't care how much it will give a huge CPU usage and lag, just configure the settings and that's all

the point of rendering mode is to render charts without lag, and without having to wait a whole hour just to record 1 CHART (as is the case with this chart) image

Stefan2008Git commented 14 hours ago

Rendering Mode should be removed from game when you can literally use OBS for that. I don't care how much it will give a huge CPU usage and lag, just configure the settings and that's all

the point of rendering mode is to render charts without lag, and without having to wait a whole hour just to record 1 CHART (as is the case with this chart) image

Doesn't matter. Buy a better CPU 😐. Work harder for money to buy it. I already got 60€ in my country since i worked harder for money. You just think this will change FNF forever, but no, it will no. Haxe server also hates rendering mode because it's useless thing i ever saw. You know Jordan, maybe i will not have the best CPU on my laptop, but i will still choose OBS for recording. Actually, you know what? I don't really care, i am just gonna leave you whatever you doing with your fork, i am porting new stuff from FNF 0.3+ to my modified Psych fork, so bye

Stefan2008Git commented 14 hours ago

Even on Windows, there's a problem with Rendering Mode. There's no sound in the finished .mp4 file. Can you fix this?

..you're supposed to use a video editor to edit it in

Awesome, now how people will get a sound Jordan? You can code everything, right? If is true, then make a function to play audio too

JordanSantiagoYT commented 11 hours ago

Even on Windows, there's a problem with Rendering Mode. There's no sound in the finished .mp4 file. Can you fix this?

..you're supposed to use a video editor to edit it in

Awesome, now how people will get a sound Jordan? You can code everything, right? If is true, then make a function to play audio too

the reason i don't do that is because it doesn't work as shown in this video

https://github.com/JordanSantiagoYT/FNF-PsychEngine-NoBotplayLag/assets/61796448/28e053a2-3963-4a5d-af3f-c509a1af6b6d

JordanSantiagoYT commented 11 hours ago

if you're willing to fix this code to make it so that it automatically adds the song audio, then be my guest

    var instPath = Paths.songPath(SONG.song, CoolUtil.difficultyString(), false);
    var voicesPath = Paths.songPath(SONG.song, CoolUtil.difficultyString(), true);

    var audioDelay:Float = !skipCountdown ? Conductor.crochet * 5 : 0;

            //Feel free to remove these traces, these just verify that they work
    trace (instPath);
    trace (SONG.needsVoices ? voicesPath : 'doesnt need voices');

    if (!SONG.needsVoices)
        process = new sys.io.Process('ffmpeg', [
            '-f', 'rawvideo',
            '-pix_fmt', 'rgba',
            '-s', lime.app.Application.current.window.width + 'x' + lime.app.Application.current.window.height,
            '-r', Std.string(targetFPS),
            '-i', '-',
            '-i', Std.string(instPath),
            '-filter_complex', '"[1:a]adelay=${audioDelay}|${audioDelay}[aout]"',
            '-map', '0:v', '-map', '"[aout]"',
            'assets/gameRenders/' + Paths.formatToSongPath(SONG.song) + '.mp4'
        ]);
    else
    //code for if the song needs voices

and this is for songPath

static public function songPath(song:String, ?difficulty:String = '', ?voices:Bool = false):Any
    {
        var instOrVoices:String = (voices ? 'Voices' : 'Inst');
        var formattedDifficulty:String = formatToSongPath(difficulty);
        if (difficulty.contains(' ')) difficulty = formattedDifficulty;
        #if html5
        return 'songs:assets/songs/${formatToSongPath(song)}/${instOrVoices}.$SOUND_EXT';
        #else
        if (difficulty != null)
        {
            var songKey:String = '${formatToSongPath(song)}/${instOrVoices}-$difficulty';
            if (FileSystem.exists(Paths.modFolders('songs/' + songKey + '.$SOUND_EXT')) || FileSystem.exists('assets/songs/' + songKey + '.$SOUND_EXT')) 
            {
                return songKey + '.$SOUND_EXT';
            }
        }
        var songKey:String = '${formatToSongPath(song)}/${instOrVoices}.$SOUND_EXT';
        if (FileSystem.exists('assets/songs/$songKey')) return 'assets/songs/$songKey';
        if (FileSystem.exists(Paths.modFolders('songs/' + songKey + '.$SOUND_EXT')))
            return Paths.modFolders('songs/' + songKey + '.$SOUND_EXT');

        else return null;
        #end
    }