search

Jordaneisenburger / fallback-studio

Magento 2 PWA fallback wrapper to easily create a custom theme on top of PWA Studio
MIT License
113 stars 28 forks source link

Facing Issues regarding various files name in fresh install. #12

Open narendravyas24 opened 5 years ago

narendravyas24 commented 5 years ago

In a fresh fallback installation we are facing various errors that seems to be because of some files names are not in proper case.

It seems as if some file names were expected to be in lower case but they are in upper case in the latest git repo.

In a fresh installation I faced this issue in three cases, due to which installation was restricted and error's were thrown. On verifying the same with the latest Magento develop branch I found that the issue was related to file names.

For Example:

https://github.com/Jordaneisenburger/fallback-studio/tree/master/src/pwa-studio/packages/venia-concept/src/RootComponents/CMS (at this location there is a file CMS.js in fallback repo.)

whereas, on looking on magento pwa develop branch, at : https://github.com/magento/pwa-studio/tree/develop/packages/venia-ui/lib/RootComponents/CMS (at this location the file name is cms.js)

similarly I am facing various issues in various files and getting error as bellow in a fresh installation: ERROR in ./src/RootComponents/CMS/index.js Module not found: Error: Can't resolve './cms' in '/var/www/html/vcs/fallback-studio/src/pwa-studio/packages/venia-concept/src/RootComponents/CMS' @ ./src/RootComponents/CMS/index.js 6:0-32 6:0-32 @ ./FETCH_ROOT_COMPONENT @ ../peregrine/lib/Router/magentoRouteHandler.js @ ../peregrine/lib/Router/index.js @ ../peregrine/lib/index.js @ ./src/index.js

Jordaneisenburger commented 5 years ago

Hi @narendravyas24,

Thanks for the issue, reason I haven't ran into this error is because I'm working on IOS that differs from Linux. As you pointed out in the latest develop version this problem is resolved so I'll update it to the latest develop again soon and the issue should be resolved.