search

Jordaneisenburger / fallback-studio

Magento 2 PWA fallback wrapper to easily create a custom theme on top of PWA Studio
MIT License
113 stars 28 forks source link

windows compatibility port #4

Open Huaoe opened 5 years ago

Huaoe commented 5 years ago

basically what I did is :

  1. replacing the pwa-studio folder with a copy of the branch *fix/windows_dev_experience**

  2. cd src/example-company/example-shop yarn add cross-env

  3. changing the root package scripts entry to :

    "watch:example-shop": "yarn workspace @fallback-studio/example-shop run watch"

thanks to command : yarn workspaces info

Questions : We should be abble to plug any version of pwa-studio folder. How can we do that ? maybe you should merge only : package.json src/example-company/example-shop/package.json

NB: I did not test this PR on a mac

Jordaneisenburger commented 5 years ago

Interesting, i see you made changes inside pwa-studio folder. When you make changes inside this folder you basically disable the ability to upgrade to the latest version of pwa-studio. So thats something you really don't wanna do. Also to be windows compatible it suggest using docker. Right now we are making changes just so we can develop but in the production env we don't need all this code if we are gonna be running on a unix based system.

But thanks for the PR when i have time i'll dive deeper into it and see of this works on a mac