search

JordyMoos / JMPriceSuggestion

Eso price suggestion addon
MIT License
2 stars 0 forks source link

Use of snapshots #9

Open JordyMoos opened 9 years ago

JordyMoos commented 9 years ago

Not sure if we should use the snapshot data if its getting old. But define old. Anyways if the snapshot data is older then the last found sale then it is no longer trust worthy i think

marcusklaas commented 9 years ago

Older than last sale? But sales come in all the time! Wouldn't that invalidate your snapshot history every few seconds?

JordyMoos commented 9 years ago

I ment the item from that snapshot.

So we make a scan of our owned guilds. In all guilds we find item A. Guild G1 has item A for the prices: 5, 100, 120 Guild G2 has item A for the prices: 40, 120

Say the history gives us a normal of 60.

So we scan another guild, we find item A there and the price sugestion gives us a nice price. And rounds it down to 40 because thats the price of G2.

But then we get a sale history for G2 for item A. (that might be the first price but that is not for sure) Then we still round down to 40 because we still think it is there. But it is not trusty anymore that it is right?

I am just guessing herre. But the point is, If i need to scan my guilds every day to get a trustful price. That would take 10 minutes each day :P

marcusklaas commented 9 years ago

Ah yes, I understand now. That makes a lot sense. When this happens, would you invalidate the snapshot data only for the item on the guild in question?

JordyMoos commented 9 years ago

Yea only for the guild in question. But i do not really invalidate the snapshot because the snapshot does not know about sales and also does not care. For the momemt i think the best solution is that price sugesstion figures out if the snapshot for that guild and item is old. In that case it ignores the effect of the last function?