search

JordyMoos / JMTradingHouseSnapshot

Creates a snapshot of all your guild trading houses so it can be used by other addons
MIT License
4 stars 0 forks source link

canContinueScanning could be simplified #1

Closed marcusklaas closed 9 years ago

marcusklaas commented 9 years ago

I have browsed through your code, and it looks very good! The comments make it very clear what's going on, even without lua experience. The readme is nice as well.

The only suggestion I have is an extremely trivial one: the logic in canContinueScanning could be simplified to return TraidingHouse.isOpen and Scanner.isScanning. This makes its behaviour a bit more evident in my view. We've talked about this in the past and I remember you weren't convinced 100% so feel free to ignore me (again!) :-P

JordyMoos commented 9 years ago

Yea you are right it is a bit too verbose. I commited your request :)

marcusklaas commented 9 years ago

Cool!

JordyMoos commented 9 years ago

Thanks @marcusklaas :)