search

JordyMoos / JMTradingHouseSnapshot

Creates a snapshot of all your guild trading houses so it can be used by other addons
MIT License
4 stars 0 forks source link

GuildId can change over time #6

Closed JordyMoos closed 9 years ago

JordyMoos commented 9 years ago

It looks like that the guild id can change over time.

So we better save the scans under the guilds name. That would be safer and also work for the kiosk sales.

JordyMoos commented 9 years ago

https://github.com/JordyMoos/JMTradingHouseSnapshot/pull/7

JordyMoos commented 9 years ago

Mmm gues we should just add the guild name to the item. Because how we store it intern does not really matter. But if we give the item to a 3rd party addon then the guildId / guildIndex can me wrong for them. But the guild name should always be fine. They should then map the name back to the real id or index if they want to work with those

JordyMoos commented 9 years ago

Gues it is best if we just add the guild name to the sale. But do not remove the guildId yet. Just say that it is depricated and we will remove it in version 2.0