Fixing ffmpeg deadlock when not consuming its error stream

JorenSix / TarsosDSP

A Real-Time Audio Processing Framework in Java

http://0110.be/tag/TarsosDSP

GNU General Public License v3.0

1.97k stars 472 forks source link

Fixing ffmpeg deadlock when not consuming its error stream #212

Closed SalomonBrys closed 1 year ago

SalomonBrys commented 1 year ago

At least on Mac, the FFMPEG process does not end and hangs indefinitely if its error stream is not consumed.

See https://github.com/JorenSix/Panako/issues/41

This PR fixes this issue.

JorenSix commented 1 year ago

Thanks for the bug report and taking the time for the PR. Unfortunately I was in the process of preparing a gradle build for which i reorganised many files. I have fixed it offline and attributed the fix to you.

SalomonBrys commented 1 year ago

👍