Steps required for landing the PR - Githubissues

Jorge-Lopes / agoric-sdk

monorepo for the Agoric Javascript smart contract platform

Apache License 2.0

0 stars 0 forks source link

Steps required for landing the PR #8

Open anilhelvaci opened 9 months ago

anilhelvaci commented 9 months ago

Context

We are planning to use this issue as the main place for discussing steps we to complete before landing the PR.

Assumptions

We assume all points have been met down below before discussing the next steps to land the PR.

Code review completed
Sufficient unit test coverage has been reached
vstorage usage has been approved by the OpCo
No linting or type errors in the code

Topics

Are there any other tests we need to implement aside from the unit tests? (Such as boot tests)
What CI checks should we focus on? Since test-all-packages fails due to these todo tests below: https://github.com/Jorge-Lopes/agoric-sdk-liquidation-visibility/blob/99fc025340e007fa01de005fa6133491d2c75d6e/packages/inter-protocol/test/smartWallet/test-psm-integration.js#L528-L532

anilhelvaci commented 9 months ago

Looking at the pr https://github.com/Jorge-Lopes/agoric-sdk-liquidation-visibility/pull/9/ we can confirm that the second clause under "Topics" in the above comment is resolved once we have our tests passing. In other words having t.todos do not break the CI.