search

Jorgen-VikingGod / Qt-Frameless-Window-DarkStyle

simple MainWindow class implementation with frameless window and custom dark style. It adds also support for titlebar and buttons (minimize, maximize, close)
1.14k stars 272 forks source link

Names of tabbed DockWidgets are very dark #14

Closed VFLashM closed 6 years ago

VFLashM commented 6 years ago

I think tabbed dock widgets still use default text color. Not sure if that's intended, but they are pretty hard to read.

Jorgen-VikingGod commented 6 years ago

@VFLashM do you have a screenshot? On which OS did you try it?

VFLashM commented 6 years ago

It was on MacOSX, Qt 5.10. Here's the screenshot:

unnamed

I fixed it by adding this line:

QTabBar::tab{
+  color:#aaaaaa;
}
Jorgen-VikingGod commented 6 years ago

looks weird... My is looking correctly (also MacOS + Qt 5.10) - tabbed dock widgets on the right and normal tabs on the left:

screen shot 2018-01-25 at 05 26 04
Jorgen-VikingGod commented 6 years ago

Looks like you did not apply the correct palette to the application.

VFLashM commented 6 years ago

Maybe it has something to do with the fact that it was docked widget, I don't know. Do I need to do something more than style? I thought it sets palette on its own.

setStyle(new DarkStyle);

On Wed, Jan 24, 2018 at 11:29 PM Jürgen Skrotzky notifications@github.com wrote:

Looks like you did not apply the correct palette to the application.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Jorgen-VikingGod/Qt-Frameless-Window-DarkStyle/issues/14#issuecomment-360357789, or mute the thread https://github.com/notifications/unsubscribe-auth/ADjSTbnik8BPr3WKneoSDBnxtxh-axY7ks5tOAMsgaJpZM4RoxVk .

Jorgen-VikingGod commented 6 years ago

This is exactly the way to use it. Really strange issue.

Can you report that this example is working? See my referenced commit

VFLashM commented 6 years ago

Does not reproduce. I guess in my case it happened because I apply style after creating widgets. On Thu, Jan 25, 2018 at 9:56 AM Jürgen Skrotzky notifications@github.com wrote:

This is exactly the way to use it. Really strange issue.

Can you report that this example is working? See my referenced commit

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Jorgen-VikingGod/Qt-Frameless-Window-DarkStyle/issues/14#issuecomment-360490389, or mute the thread https://github.com/notifications/unsubscribe-auth/ADjSTemofRPUePErR-2wkbYJUZk1-a09ks5tOJYsgaJpZM4RoxVk .

Jorgen-VikingGod commented 6 years ago

really strange happens here. But good to know, that it is fixed now for your application. If it appears again, please open a new issue.