search

JorgenVatle / meteor-vite

⚡ Replace Meteor's bundler with Vite for blazing fast build-times
MIT License
32 stars 10 forks source link

vite 5 support #126

Closed harry-73 closed 9 months ago

harry-73 commented 9 months ago

Hi,

Is there plan to support vite 5?

Thanks.

JorgenVatle commented 9 months ago

There is! I don't believe the plugin is incompatible with Vite v5. We're just waiting on Meteor v3, as Vite v5 dropped support for Node.js 14 - which is the version Meteor v2 uses internally.

If there is a need for Vite v5 for users on Meteor v2, there are certainly ways to get around this, as I assume most people will have a newer version of Node.js already installed that we can use instead when firing up Vite from Meteor. But I've opted not to put much time into that as I don't think the complexity of managing two Node.js installs for your environment makes the upgrade worthwhile.

But again, I'm open to add support if there is a real need. I'd love to hear some use cases. 🙌

harry-73 commented 9 months ago

In fact, I use the package vite-plugin-vuetify and it has as peer dependencies vite >=5:

"peerDependencies": {
        "vite": ">=5",
        "vue": "^3.0.0",
        "vuetify": "^3.0.0"
      }

So I have some error running npm.

But at least everything to work.

JorgenVatle commented 9 months ago

Yeah, most plugins have recently upped their major version to match the new Vite release. Usually there aren't any major changes apart from the Vite v5 version bump.

https://github.com/vuetifyjs/vuetify-loader/blob/master/packages/vite-plugin/CHANGELOG.md#-breaking-changes

The following snippet should fix those warnings for you. I'll be sure to add Vite v4 as a peer dependency for our plugin so npm won't try to install incompatible plugin versions.

meteor npm i vite-plugin-vuetify@1
harry-73 commented 9 months ago

Thanks.