Jorixon / JASM

Just Another Skin Manager
GNU General Public License v3.0
61 stars 7 forks source link

fix: Improve mod enabling logic during install #167

Closed Davoleo closed 3 months ago

Davoleo commented 3 months ago

Previous behaviour: if the checkbox "Enable this mod and disable others?" was unchecked the newly installed mod would be left enabled. Problem: if there are other mods already installed to a certain CharEntry the newly installed mod is left enabled and needs to be disabled manually to avoid mod conflict. Solution: Added piece of logic that checks if there are other enabled mods on the same CharEntry and, in case there are, disables the newly installed mod automatically.

No logic changes in case the checkbox mentioned above is checked.

PS: feel free to tell me if there are better ways to do something in code, the codebase seems is quite big and i still haven't even scratched the surface in exploring it, and i also don't have much experience with WinUI 3.