Jorixon / JASM

Just Another Skin Manager
GNU General Public License v3.0
148 stars 16 forks source link

Mod Update updating the existing mod entry #200

Closed CazzoPMX closed 1 week ago

CazzoPMX commented 3 months ago

Is your feature request related to a problem? Please describe. The Mod-Update function is a neat little thing to have, but it's a bit of a chore to reapply custom thumbnails & display names, not to mention replacing the mod in the presets I created.

Describe the solution you'd like Would it be possible to have an option to make the "Add new Mod" Dialog (which gets spawned after clicking on an entry with Updates, and then clicking Download/Install) to actually replace the GUID that has initiated said update? For keep-sake it could store the old version as a _bk and auto disable it. To be precise, what I meant was having an Option that does the following things

Describe alternatives you've considered Manually doing things and just living with it

Additional context On that matter, I may tell you that choosing a different thumbnail during said "Add new Mod" dialog does not keep the Thumbnail I selected with "Set mod preview image" and instead stays on the automatically selected one, so I have to manually set it properly afterwards. I may do an extra Issue for that though.

CazzoPMX commented 3 months ago

An alternative take could be that, when saving such an "New Mod" from the Update, to check if the folder already has a mod with the same Display/CustomName, and prompting the user with a dialog "Did you intend to replace an existing mod or add a new one?" -- Although now that I think about it, it might as well just show a dropdown with the mods of said folder and ask to replace any (still with the idea of only prompting all of that when selecting said option in the first dialog to begin with)

It could also just replace the old GUID in the presets with the new ones (which may be easier in terms of mod management) instead of reassigning an existing GUID (which instead would save the effort of checking any presets for existence of such)

(Sorry if these edits generated an individual email each, idk if that happens >.<)

Jorixon commented 3 months ago

I like your suggestion! I'll see if I can get this implemented

Edits don't generate emails so no problem there :)