search

Jorixon / JASM

Just Another Skin Manager
GNU General Public License v3.0
148 stars 16 forks source link

feat: support deleting mod in grid view #213

Closed yuukidach closed 2 months ago

yuukidach commented 2 months ago

support Delete Mod button in grid view

image

BEGIN_COMMIT_OVERRIDE feat: Support deleting mod in gallery view (#213) Thanks @yuukidach END_COMMIT_OVERRIDE

Jorixon commented 2 months ago

I think adding a delete mods dialog with a confirmation could be a good idea, just to avoid cases where the user accidentally clicks the delete mod button instead of the option above. Even though the DeleteModBySkinEntryId() by default moves the mod to the recycle bin, I don't think it's that obvious for the user.

Something similar to the delete dialog on the detailed view. Perhaps a smaller version?

yuukidach commented 2 months ago

Hi @Jorixon ,

Thanks for the suggestion. I have made some changes to he PR:

  1. If user clicks on the delete button, a dialog will pop up
  2. The user can check the "Do not ask again" checkbox to avoid frequent confirmations.

Here is an example image image

Jorixon commented 2 months ago

Nice! I'll do a quick test and code review tomorrow

Ui looks good 👍

yuukidach commented 2 months ago

All comments in the CR has beed resolved, please have a look again @Jorixon