search

Jorl17 / half-life-source-hd-sound-fix

Fix for missing sounds in HL:Source with HD textures/models
GNU General Public License v2.0
8 stars 2 forks source link

Please explain what the script actually does to the VPKs #5

Open HbmMods opened 6 years ago

HbmMods commented 6 years ago

Hey,

from what I've gathered, your script is supposed to download and insert the missing sounds into hl1_hd's VPK files. However, since the installation process was as pleasant as forcefully removing one's balls with a hacksaw (mostly thanks to unvpk), I tried to do what the script is supposed to do manually. To my surprise, it appears as if all the supposedtly missing sounds are in fact inside the VPK, therefore I wanted to ask: what exactly does the script do? Does it redownload the files because they are in an unplayable format, or does it move them because they are in the wrong directory? I can't wrap my head around it since the script's (or more precisely, the error's) description states that there should be sounds missing, but they seem to be all there.

Jorl17 commented 6 years ago

Hi,

It's been a long time since I touched this. All this script does is automate the process described in this issue. I am unsure if this fix is still required, and please note that the version I used myself did not use unvpk (it used the official valve tool) and was tested on a Mac. I'll accept pull requests :)

Apparently, some weapons are missing reload sounds from their files:

I can confirm that two weapons actually miss reload sounds. Those being glock and mp5 (9mmar).

In adddition to these issues, it seems there are problems mounting archives directly from the VPK, so the sounds must be extracted:

The models I posted would fix the reload sound issues, however, it appears that users, including @mickeylyle, reported that firing sounds of weapons were missing.

In the hl1_hd folder, several VPKs can be found, which contain as well sounds used the HD pack. The problem is that the game actually fails to load these sounds from the archive. This appears to affect Linux users. At this time, it is unknown if Apple and other non-Windows OS users are affected.

HbmMods commented 6 years ago

Hey again,

than's for the quick response, extracting the VPK sounds into the right location mostly did the trick. The reload sounds still don't work, but according to @malortie, the sounds aren't played because they are bound to the model, and those don't seem to trigger them. I'll look into his approach on fixing that, thank you for your reply :)