Handle spaces in jvm_options

Jorl17 / jar2app

Convert any Java jar to a Mac OS X .App bundle. No external tools needed, no funky parameters, it just works.

GNU General Public License v2.0

413 stars 56 forks source link

Handle spaces in jvm_options #18

Closed akbcode closed 6 years ago

akbcode commented 6 years ago

If the display name or working directory contain spaces, the app won't run. Fixed to use shlex.split instead of just split. And enclosed working dir and display name in quotes.

Jorl17 commented 6 years ago

Thank you for your PR! I think there might still be issues if paths have " in their names (which should not be allowed, but, alas, it happens), but we'll leave that for another time.

Merging.