search

Jorricks / iCal-library

ICalLibrary - Fast, yet simple, iCalendar reader with excellent recurrence support in Python
https://jorricks.github.io/iCal-library/
MIT License
12 stars 0 forks source link

Pendulum 3.0.0 breaks package #10

Open sanieldalib opened 7 months ago

sanieldalib commented 7 months ago

Hey there, first of all thank you so much for an amazing package. I've spent so long looking for something that handles recurring events well.

When installing via pip install iCal-library v3.0.0 of Pendulum gets installed. When attempting to use the package the following error is thrown: 

ImportError: cannot import name 'Period' from 'pendulum' (/Users/dsalib/Developer/oasis/venv/lib/python3.9/site-packages/pendulum/__init__.py)

I resolved this by pinning to v2.1.1 of Pendulum. You may want to do the same, or upgrade to support Pendulum v3.

Cheers!

Jorricks commented 7 months ago

Hey @sanieldalib,

First of all, you made my day. Thanks for the compliments and I am happy to hear I helped you out! I will draft a new release with a pendulum<3.0.0 restriction for now, and once I have the time I will upgrade it to pendulum 3.0.0.

Cheers!

Jorricks commented 7 months ago

I created a new release; 0.2.3. This should correctly pin the dependencies :).

I also proceeded to check what is needed to support Pendulum 3.0.0. Unfortunately, they dropped some functionality which allowed us to create custom timezones. This functionality is available in the CPython test suite, but simply copy-pasting doesn't feel right. Therefore I opened the following topic; https://discuss.python.org/t/making-custom-timezones-possible-using-the-standard-library/45008. Let's see what that brings.

I will keep this issue open until we have support for Pendulum 3.0.