search

JorrinKievit / react-ts-tradingview-widgets

This is a React component library for TradingView Widgets
https://tradingview-widgets.jorrinkievit.xyz/
MIT License
154 stars 48 forks source link

fix: #47 added optional countryFilter prop to EconomicCalendarProps #48

Closed Branch closed 9 months ago

Branch commented 9 months ago

closes #47

JorrinKievit commented 9 months ago

👋 Thanks for the PR! You also need to add it in the component itself -> https://github.com/JorrinKievit/react-ts-tradingview-widgets/blob/63a983c00cbd6616d001201cf756c1ae35849875/src/components/EconomicCalendar.tsx#L41

And could you also add it to the docs? https://github.com/JorrinKievit/react-ts-tradingview-widgets/blob/main/docs/docs/components/EconomicCalendar.md

Thanks!

Branch commented 9 months ago

Sorry I was too quick! Will have it fixed.

Branch commented 9 months ago

@JorrinKievit I noticed during this that the component has the prop currencyFilter which is unused, with the desc in the docs "Default countries". I believe that's the original mistake. But removing that will be in a different ticket in my opinion!

JorrinKievit commented 9 months ago

Looool haha that was a dumb mistake 😂 . Will remove it rn