search

JorrinKievit / react-ts-tradingview-widgets

This is a React component library for TradingView Widgets
https://tradingview-widgets.jorrinkievit.xyz/
MIT License
163 stars 50 forks source link

Add attribution link below the widgets #5

Closed mayrsascha closed 1 year ago

mayrsascha commented 2 years ago

I was in contact with the Tradingview support and they checked my site which uses this library. They mentioned that we shouldn't use their widgets without the attribution at the bottom of the widget (not the one inside the widget) as seen here:

image

It is not showing on the demo page as well, so I guess this is not showing on purpose?

JorrinKievit commented 2 years ago

Hey, also just got in contact with TradingView. I was not aware the attribution was required. I think I will be integrating the attribution in the components, with customizable styling.

JorrinKievit commented 2 years ago

Fixed in 1.0.9

0xsol1d commented 2 years ago

I know this issue is closed already, but I reached out tradingview for the exact same issue, and they told me something different. They sended me a bunch of PNGs to implement into my website (for example into the footer), if I want to delete the attribution line, so it would be nice to implement that the attributtion is switchable. That´s what they wrote (google-translated):

We are very pleased that you have integrated our widgets. On the chart page, the logo must have do_follow signature. See screenshot in the attachment. I also attach the logos. On the page of the Frankfurt Stock Exchange, below footer is a great example: https://www.boerse-frankfurt.de Let us know if you have any further questions. Thank you in advance.

JorrinKievit commented 2 years ago

Hm that's interesting. They indeed contacted me and asked me to include the attribute under the widget. Which is why I only added styling customization so you could position it anywhere below the chart 🤔

0xsol1d commented 2 years ago

Ok, maybe they decide differently on a case-by-case basis. you have built a framework to use the widgets, maybe they rate it different than a website. Or maybe it was also about the fact that it has to appear in the framework at all and must not be omitted from the outset.

JorrinKievit commented 2 years ago

Ye I assume the last part, could contact for more clarification

emorling commented 2 years ago

I know this issue is closed already, but I reached out tradingview for the exact same issue, and they told me something different. They sended me a bunch of PNGs to implement into my website (for example into the footer), if I want to delete the attribution line, so it would be nice to implement that the attributtion is switchable. That´s what they wrote (google-translated):

We are very pleased that you have integrated our widgets. On the chart page, the logo must have do_follow signature. See screenshot in the attachment. I also attach the logos. On the page of the Frankfurt Stock Exchange, below footer is a great example: https://www.boerse-frankfurt.de Let us know if you have any further questions. Thank you in advance.

Can you attach the screenshot they sent you, please? 🙏🏽 Or a link to your implementation of their comments?