search

JorrinKievit / tmdb-js

A typesafe API wrapper for the TheMovieDatabase API for Node and the Web
10 stars 1 forks source link

Updated cast and crew credits #22

Closed newmoneybigbucks closed 11 months ago

newmoneybigbucks commented 11 months ago

I updated all the "get credit" types to include both "crew" and "id" fields in addtion to the "cast" field. I created a number of new base types to build these cast and crew types from, and modifying everything to use those new base requests.

Get credits for movie and tv were modified, along with the get credits and get aggregate credits from the person endpoint

changeset-bot[bot] commented 11 months ago

🦋 Changeset detected

Latest commit: 1569d3bbdeddce511aab0ee08be7437d059570f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ------------ | ----- | | tmdb-js-core | Patch | | tmdb-js-web | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

JorrinKievit commented 11 months ago

Could you also run the linter/formatter? Pipeline is failing. Added it a few days ago 😄

JorrinKievit commented 11 months ago

Just these 2 small things, after looks good to merge. Thanks for your effort 🙂

newmoneybigbucks commented 11 months ago

Updated the fields, and I changed the multi search request type in the search endpoint to use the base request types I made earlier (I missed that changing that one type initially)

JorrinKievit commented 11 months ago

Approved when you fix the conflicts and run the formatted so the pipeline passes @newmoneybigbucks 🙂

newmoneybigbucks commented 11 months ago

Approved when you fix the conflicts and run the formatted so the pipeline passes @newmoneybigbucks 🙂

Got it done. Sorry for all the sort of empty commits. I had a formatting issue, I ran the scripts in the repo to lint and format it, and the format script changed the formatting of the conditional type used to retrieve the correct result types for append to response. It removed the extra spaces before each ? : set in append-to-response.ts ResponseTypeFor, but github ci requires that they exist . This is just as a heads up incase you run into a similar issue (might just be a me issue where I ran something wrong or did not have some updated settings for the formatter on my branch)

JorrinKievit commented 11 months ago

All good, thanks for your work!