JorrinKievit / tmdb-js

A typesafe API wrapper for the TheMovieDatabase API for Node and the Web
9 stars 1 forks source link

Added missing fields (TMDB API docs do not list all the fields the endpoint can return) #30

Closed newmoneybigbucks closed 6 months ago

newmoneybigbucks commented 6 months ago

TMDB API docs give an incorrect person get combined credits result structure. The documentation shows the structure as looking the the movie credits response when in reality the data it returns can either look like the movie credits response OR the tv credits response. I added the movie and tv specific fields as optional fields to the cast and crew types for the combined credits types. This means if you were working with "original_title" from combined credits you will now have to check for undefined before using it. Additionally the get tv details was missing an "adult" boolean field, so I added that to TVGetDetailsBaseResponse

changeset-bot[bot] commented 6 months ago

🦋 Changeset detected

Latest commit: 0c20bfbbab1352e2bff444bcbbd8037e2c10313e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ------------ | ----- | | tmdb-js-node | Minor | | tmdb-js-web | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR