JorrinKievit / tmdb-js

A typesafe API wrapper for the TheMovieDatabase API for Node and the Web
10 stars 1 forks source link

Append to response is not typed anywhere needed #6

Closed paolodelfino closed 1 year ago

paolodelfino commented 1 year ago

For example, tv show's getDetails is not append to response typed

getDetails: <T extends TVAppendToResponse[]>(tvId: number, params?: TVGetDetailsParams<T>) => Promise<TVGetDetailsResponse>;

but movie's one is

getDetails: <T extends MoviesAppendToResponse[]>(movieId: number, params?: MoviesGetDetailsParams<T>) => Promise<GetDetailsResponse<T>>;
JorrinKievit commented 1 year ago

Should be fixed in 1.1.2