search

JoryHogeveen / off-canvas-sidebars

This plugin will add various options to implement off-canvas sidebars in your WordPress theme based on the Slidebars jQuery plugin.
GNU General Public License v2.0
13 stars 4 forks source link

Can't view certain pages when logged into wordpress/plugin is installed/in Safari #107

Closed cariirwin closed 1 year ago

cariirwin commented 3 years ago

Describe the bug

When all 3 of these conditions are met....

  1. The Off-Canvas Sidebars plugin is activated
  2. I am logged into my wordpress site
  3. I am using Safari...
    • My Simple Job Board jobs are fully blank
    • My events page created by The Events Calendar is fully blank

Steps to reproduce the behavior:

  1. Use Safari
  2. Log into your wordpress site
  3. Install Off-Canvas Sidebars plugin plus either The Events Calendar or Simple Job board and create an entry
  4. Try to preview the job listing and/or the auto-created /events page (not the single event page)
  5. Deactivate the Off-Canvas Sidebars plugin and see if you can preview

Expected behavior

I expected to be able to see my events page and my job listings

Screenshots

If applicable, add screenshots to help explain your problem.

Specifications

Additional context

Add any other context about the problem here.

JoryHogeveen commented 3 years ago

Hi @cariirwin

I checked your page's and can see all content. As you've mentioned you need to log in in order to see the error, this actually tells me it's not related to this plugin but most likely a bug in some other content being rendered on the page if you are an admin.

Unfortunately I do not have Safari so I cannot test on that browser since it is only supported for iOS. Even though, since the bug only happens when you are logged in I doubt the browser would make any difference.

For now there isn't much I can do, please fully revalidate your HTML markup or allow me to log in to a dev environment where you can reproduce the bug.

Cheers, Jory

cariirwin commented 3 years ago

Hi Jory, Here is a login to the environment. If you take a look, you'll see the error goes away if I deactivate the Off-Canvas Sidebar plugin: https://edz.wpengine.com/wp-admin/ Test_HR zonsop-sogcuv-2Jiqxy

The plugins it's conflicting with are used here on the site:

  1. The Events Calendar Pro: https://edz.wpengine.com/wp-admin/edit.php?post_type=tribe_events
  2. Simple Job Board: https://edz.wpengine.com/wp-admin/edit.php?post_type=jobpost

Thanks for looking into this!

Best, Cari

On Wed, Sep 1, 2021 at 1:59 AM Jory Hogeveen @.***> wrote:

Hi @cariirwin https://github.com/cariirwin

I checked your page's and can see all content. As you've mentioned you need to log in in order to see the error, this actually tells me it's not related to this plugin but most likely a bug in some other content being rendered on the page if you are an admin.

Unfortunately I do not have Safari so I cannot test on that browser since it is only supported for iOS. Even though, since the bug only happens when you are logged in I doubt the browser would make any difference.

For now there isn't much I can do, please fully revalidate your HTML markup or allow me to log in to a dev environment where you can reproduce the bug.

Cheers, Jory

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JoryHogeveen/off-canvas-sidebars/issues/107#issuecomment-910082630, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVLF3NB5GEUI4BF7UD6HAALT7XTOVANCNFSM5CZZN7OQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

JoryHogeveen commented 3 years ago

Hello @cariirwin

The login data you've provided seems to be incorrect. Also, please do not share these on GitHub (if you reply to this email you will also share it on GitHub). Could you email me on info@keraweb.nl?

Cheers, Jory

JoryHogeveen commented 3 years ago

Hello @cariirwin

Thank your for the corrected login. I've checked your page and found that the HTML markup isn't correct. It looks like your theme already supports various slideout's similar to those of this plugin. Also, the admin bar is located inside the site wrapper, this should be a direct child of the <body> tag. This is most likely a theme issue. Secondly, it looks like you are using a fixed menu. In order this to work you'll need to set the compatibility mode to "Legacy CSS" (CSS2).

Let me know if this helps!

Cheers, Jory

JoryHogeveen commented 3 years ago

Note, I just changed the compatibility mode to Legacy CSS and it already works a lot better.