search

JoryHogeveen / off-canvas-sidebars

This plugin will add various options to implement off-canvas sidebars in your WordPress theme based on the Slidebars jQuery plugin.
GNU General Public License v2.0
13 stars 4 forks source link

ocs-site white space #60

Closed overcatbe closed 5 years ago

overcatbe commented 5 years ago

Describe the bug

White space after content. Firstly - very much thank you for this awesome plugin. :)

Steps to reproduce the behavior:

All time white space after content with fixed height as described here https://github.com/adchsm/Slidebars/issues/10

Specifications

JoryHogeveen commented 5 years ago

Hi @overcatbe,

Can you share a link so I can take a look at you site structure and CSS?

Thanks, Jory

overcatbe commented 5 years ago

it's a site in making so ugly as of now :) https://www.croatian-apartments.com/?page_id=180 thanks!

overcatbe commented 5 years ago

the trigger shows on mobile width. :D

JoryHogeveen commented 5 years ago

Hi @overcatbe,

It seems your structure is incorrect. You current HTML shows this:

<body>
   <div id="page">
      Site content
   </div>
   <div id="ocs-site">
      Canvas container
   </div>
</body>

While it should show this:

<body>
   <div id="ocs-site">
      <div id="page">
         Site content
      </div>
   </div>
</body>

Please check if your installation is using the correct hooks and the hooks are placed correctly. See: installation guide

Let me know! Jory

JoryHogeveen commented 5 years ago

Oh, since you are using Storefront, see this page for compatible hooks: https://github.com/JoryHogeveen/off-canvas-sidebars/wiki/Compatible-theme-hooks#storefront-woocommerce

Keep in mind though that the wp_footer hook is not officially supported yet, it's in development here: PR v0.5.3: https://github.com/JoryHogeveen/off-canvas-sidebars/pull/58

overcatbe commented 5 years ago

indeed! i need to learn to read! thanks!

JoryHogeveen commented 5 years ago

No problem! If you run into any problems let me know!

PS: if you like the plugin, please consider leaving a nice review, it will help the plugin grow https://wordpress.org/support/plugin/off-canvas-sidebars/reviews/#new-post