search

JoryHogeveen / off-canvas-sidebars

This plugin will add various options to implement off-canvas sidebars in your WordPress theme based on the Slidebars jQuery plugin.
GNU General Public License v2.0
13 stars 4 forks source link

Trigger not working #80

Closed vanbrew closed 4 years ago

vanbrew commented 4 years ago

Description

Hey there, I have completed the theme setup (using simple theme setup) and created a side menu. I've added the trigger to my header but it doesn't trigger the menu. When I inspect the element I can see it's all there.

Specifications

JoryHogeveen commented 4 years ago

Hello @vanbrew

Please provide the following information so I can see what is happening:

When I inspect the element I can see it's all there.

I think it might be there but on the wrong location.

vanbrew commented 4 years ago

Hey Jory,

Here is the link: https://www.connectcasemanagement.vanessabrewster.com/ https://www.connectcasemanagement.vanessabrewster.com/

Please excuse the undercooked CSS ;)

Cheers, Van

From the desk of Vanessa Brewster 0450 737 356 vanessabrewster.com https://vanessabrewster.com/ EMAIL mailto:vanessa.brewster@me.com SHOP https://www.etsy.com/au/shop/vanbrewed GRAM https://www.instagram.com/vanbrewed/

On 21 Feb 2020, at 9:06 pm, Jory Hogeveen notifications@github.com wrote:

Hello @vanbrew https://github.com/vanbrew Please provide the following information so I can see what is happening:

Link to a page where this occurs Or if that is a local environment: Javascript error log The HTML of that page header.php and footer.php of your theme (screenshot is also fine). If this is private information, please send it to info@keraweb.nl mailto:info@keraweb.nl When I inspect the element I can see it's all there.

I think it might be there but on the wrong location.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JoryHogeveen/off-canvas-sidebars/issues/80?email_source=notifications&email_token=AOTW6CG5YZLWVVXJ65EIGZ3RD6RTXA5CNFSM4KY4B7P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMSGA5Y#issuecomment-589586551, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOTW6CAOJOJ3S2OOQRZC2H3RD6RTXANCNFSM4KY4B7PQ.

JoryHogeveen commented 4 years ago

Hello @vanbrew

You have an error in your page: Uncaught ReferenceError: Baseliner is not defined at window.onload ((index):16) Not sure what it is but that will need to be fixed first.

vanbrew commented 4 years ago

Hey Jory,

I’ve removed that script now!

Cheers, Van

From the desk of Vanessa Brewster 0450 737 356 vanessabrewster.com https://vanessabrewster.com/ EMAIL mailto:vanessa.brewster@me.com SHOP https://www.etsy.com/au/shop/vanbrewed GRAM https://www.instagram.com/vanbrewed/

On 21 Feb 2020, at 10:40 pm, Jory Hogeveen notifications@github.com wrote:

Hello @vanbrew https://github.com/vanbrew You have an error in your page: Uncaught ReferenceError: Baseliner is not defined at window.onload ((index):16) Not sure what it is but that will need to be fixed first.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JoryHogeveen/off-canvas-sidebars/issues/80?email_source=notifications&email_token=AOTW6CGIMVOXIS553MKPQ33RD64RPA5CNFSM4KY4B7P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMSN3VI#issuecomment-589618645, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOTW6CBB27F4FW6B27IORHLRD64RPANCNFSM4KY4B7PQ.

JoryHogeveen commented 4 years ago

Hmm this is weird.. for some reason the script won't initialize. If I run ocsOffCanvasSidebars.init() in the console everything works fine..

JoryHogeveen commented 4 years ago

I think I've found the issue.

It looks like wp_footer(); is called before the website_after hook. It should be called after that: https://github.com/JoryHogeveen/off-canvas-sidebars/wiki/Theme-setup#simple-theme-setup

vanbrew commented 4 years ago

Oh amazing, that worked!

Thank you so much.

Cheers, Van

From the desk of Vanessa Brewster 0450 737 356 vanessabrewster.com https://vanessabrewster.com/ EMAIL mailto:vanessa.brewster@me.com SHOP https://www.etsy.com/au/shop/vanbrewed GRAM https://www.instagram.com/vanbrewed/

On 23 Feb 2020, at 2:17 am, Jory Hogeveen notifications@github.com wrote:

I think I've found the issue.

It looks like wp_footer(); is called before the website_after hook. It should be called after that: https://github.com/JoryHogeveen/off-canvas-sidebars/wiki/Theme-setup#simple-theme-setup https://github.com/JoryHogeveen/off-canvas-sidebars/wiki/Theme-setup#simple-theme-setup — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JoryHogeveen/off-canvas-sidebars/issues/80?email_source=notifications&email_token=AOTW6CFFABIQBAYHTESYW3DREE62HA5CNFSM4KY4B7P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMVCSZA#issuecomment-589965668, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOTW6CFTTFSF2SJ4MAXU2TDREE62HANCNFSM4KY4B7PQ.

JoryHogeveen commented 4 years ago

No problem! Also, if you like the plugin, please consider leaving a nice review, it will help the plugin grow 🙂 https://wordpress.org/support/plugin/off-canvas-sidebars/reviews/ Thanks, Jory