search

JoryHogeveen / view-admin-as

View the WordPress admin as a different role, switch between users, temporarily change your capabilities, set default screen settings for roles, manage your roles and capabilities.
https://wordpress.org/plugins/view-admin-as/
GNU General Public License v2.0
45 stars 3 forks source link

URE Integration: Fix the level at which the View Admin As group appears in the URE Custom Capabilities UI #135

Closed pbiron closed 3 months ago

pbiron commented 3 months ago

Fixes #134

Proposed Changes

Screenshot w/ PR applied

vaa-ure-custom-caps-after-pr

Compare the above screenshot with the one in #134

pbiron commented 3 months ago

Note: I created the PR in a separate branch of my fork of VAA (which was branched from the current VAA dev branch) and had hoped that GitHub would make the PR against VAA dev but it did it against master. Sorry about that.

JoryHogeveen commented 3 months ago

Hi @pbiron Thank you for the PR! I am wondering whether this is a change in URE which needs backwards compatibility. Do you know of any changes in the URE code lately that lead to this change?

pbiron commented 3 months ago

As far as I know, it's not a recent change in URE. I noticed the problem a long time ago (don't remember exactly how long ago, but at least 2-3 years) but promptly forgot about it.

I was reminded of it the other day when I had to fix one of my own plugins that also hooks into ure_capabilities_groups_tree, so I opened the ticket/PR before I forgot about it again ;-)

JoryHogeveen commented 3 months ago

Okidoki, in that case I doubt that there is a need to support legacy versions so I'm going ahead an merge this PR, thanks again! It will be release in the next MR (no idea when that would be as this is the first patch for it).

pbiron commented 3 months ago

certainly no rush for you to release a new version just for this