search

JoryHogeveen / view-admin-as

View the WordPress admin as a different role, switch between users, temporarily change your capabilities, set default screen settings for roles, manage your roles and capabilities.
https://wordpress.org/plugins/view-admin-as/
GNU General Public License v2.0
45 stars 4 forks source link

Conflict with Ultimate Member - "Form Changed" popup #93

Closed neilgilmour closed 6 years ago

neilgilmour commented 6 years ago

Expected Behavior

Navigating Ultimate Member pages in WP admin is a smooth and pleasant journey. Or at least as smooth and pleasant as it can be for Ultimate Member.

Actual Behavior

Navigating Ultimate Member pages in WP admin is not a smooth and pleasant journey. Every page change triggers a "Leave this page? content not saved" error.

Steps to Reproduce the Problem

  1. Install VAA
  2. Install Ultimate Member
  3. navigate round some UM pages
  4. throw computer out of window in frustration

Specifications

JoryHogeveen commented 6 years ago

@neilgilmour Quick question, are you in a view when this error shows? And are you using the free version?

neilgilmour commented 6 years ago

No, default view.

Free version of UM

On Wed, 27 Jun 2018 at 19:09, Jory Hogeveen notifications@github.com wrote:

@neilgilmour https://github.com/neilgilmour Quick question, are you in a view when this error shows? And are you using the free version?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JoryHogeveen/view-admin-as/issues/93#issuecomment-400778328, or mute the thread https://github.com/notifications/unsubscribe-auth/ADSFVi00SAr-y1kqCyhUQ_6xhM8hC-NDks5uA8pfgaJpZM4U5zbA .

JoryHogeveen commented 6 years ago

Are you sure the issue is with VAA? Just installed Ultimate Member free on my dev site and can't find any noticeable changes in load time.

JoryHogeveen commented 6 years ago

Ah, hold on, I get what you mean! It's not about the load time but about the form-notice you get. Funny thing, I noticed this with WooCommerce etc. too but it didn't came to mind that it could be VAA. Will look into this!

JoryHogeveen commented 6 years ago

@neilgilmour See commit 7724e22. The problem was that JS was triggering a change on load to start some conditional handing but that also triggers the browser into believing that something in a form object was actually changed (which is not the case).