Joschuka / fmt_xc3

1 stars 0 forks source link

Support for other Xenoblade game anims #1

Open nanogram opened 11 months ago

nanogram commented 11 months ago

Not an issue, just checking if there are any potential plans to support animations from other xenoblade games, primarily xb2 & xbde (prob in another plugin).

Joschuka commented 11 months ago

The animation format for these was a simpler version of XC3's, I pushed an update for these. Do note that I won't fix skinning issues for now as the way to handle it properly is quite convoluted and I'm moving on to other projects.

nanogram commented 11 months ago

It works for main characters & enemies, broken for objects, npc, and weapons for DE. Good enough for now.

Joschuka commented 11 months ago

Let's keep this open even if I don't end up fixing things immediately, it makes things easier to track. I'll take a quick look at these and see if it's easy enough to fix, I only tested on a few main characters for both.

Joschuka commented 11 months ago

I took a quick look, there were some issues for the chr auto-load for some weapons, should be fixed with a better approach. NPCs are indeed not working, but I don't have the time/motivation to troubleshoot why for now, PRs are welcome.

nanogram commented 10 months ago

image Armu family animations in particular are very broken.

Joschuka commented 7 months ago

I got back to working on XC this week for a personal XC1DE project. I was able to take a proper look at those broken animations and fix several issues in 7728119 : -new semantic I never saw before -some animation data was in model space, for better precision -some animations had an internal bone remap which is name based, which allows them to share anims between species. Hence why some of them were so broken

I eventually plan to have proper skinning but I'm done for now, I'll go back to the franchise in several weeks again most likely for XC2.

nanogram commented 6 months ago

Errors on certain XCDE files(using 77281191):

en070101-en070106, en150104(square plane)

line 848, in LoadModel
ofs, size, stride = vBufferInfo[skinBufferInfo[2]][:3]
UnboundLocalError: local variable 'skinBufferInfo' referenced before assignment

en110100, np020000(wii models)

line 664, in LoadModel
assert 0
AssertionError