search

JoseExposito / touchegg

Linux multi-touch gesture recognizer
GNU General Public License v3.0
3.65k stars 168 forks source link

client: Disable autostart during a Cinnamon session. #626

Closed mtwebster closed 1 year ago

mtwebster commented 1 year ago

Cinnamon acts as a client, with more or less the same capabilities, so avoid interference between the two.

JoseExposito commented 1 year ago

Hi!

Do you know if the Cinnamon desktop implements a custom client? Like what Gala does on elementary OS, for example.

If so, I think that it'd make sense to include this patch downstream for backwards compatibility. Including it here would cause issues to users running an old version of Cinnamon without multi-touch support.

clefebvre commented 1 year ago

Hi Jose,

It would only affect people who upgrade to the latest touchegg without upgrading Cinnamon. Most distributions either upgrade both or neither.

In Ubuntu for instance touchegg is still at version 1.1.0, even in non-LTS releases.

We're killing the touchegg client in Cinnamon 5.8 to work around this but a proper solution is for it not to start in a Cinnamon session. Eventually we'll want to remove that work around, the sooner the better.

Patching touchegg's desktop file is only a solution downstream (for us in Mint), it wouldn't help unless all distributions shipping Cinnamon 5.8+ did it.

clefebvre commented 1 year ago

I suppose you could check the cinnamon version within the client.. it's a bit overkill though.

clefebvre commented 1 year ago

Hi Jose,

We've added an override in cinnamon-session 5.8.1 so that touchegg doesn't get started in a Cinnamon session.

With this in place we no longer need to kill the client and the autostart file no longer needs to be modified.

https://github.com/linuxmint/cinnamon-session/commit/613b15f85697aec1aa5e268a6be94b6c4f8212de

JoseExposito commented 1 year ago

Thanks for fixing this in the Cinnamon desktop, it looks like the right place for the fix, and sorry for the delay on my side.

If you don't mind, I'm going to close this pull request as it is not longer needed.