Closed giantoppai closed 5 years ago
Thanks for the pull request. I'm afraid I'm not able to accept it for the following reason: Chrome's design guidelines do not allow an extension to have both a page_action
and a browser_action
at the same time. Check this link for some reasoning. You can easily check this by loading the extension on Google Chrome.
It's not a problem in Firefox. Although that means it would have to be a separate extension.
This is a cleaner way to use Quick Bookmark to Folder. The icon will only appear if the user wants to make a bookmark.
It creates a button in the address bar, called the "page action," that will appear when the bookmark star icon is clicked. Removing the bookmark will hide the page action with it.
Note: Clicking the bookmark star icon and then using either the page action or browser action will create a duplicate bookmark. Please add a feature to delete the old bookmark.
Edit: I added a way to prevent duplicate bookmarks.