Josee9988 / MinifyAll

A 𝗩𝗦𝗖𝗼𝗱𝗲 𝗺𝗢𝗻𝗢𝗳𝗢𝗲𝗿 for JS, JSON/C, CSS, and HTML, you will love its simplicity! 🌟 π˜Ύπ™€π™’π™₯π™§π™šπ™¨π™¨ and π™œπ™―π™žπ™₯ files and folders πŸ“¦ Reduce your bundle and file sizes with lightning speed ⚑
https://minifyall.jgracia.es/
GNU General Public License v3.0
71 stars 13 forks source link

Not minifying anymore #102

Closed maxresnikoff closed 3 years ago

maxresnikoff commented 3 years ago

Won't minify anything anymore. Usually have it to minify to a new .min file on save, but not working. Also right-clicking and manually minifying and preserving original no longer works. Have re-installed the extension but no luck.

Josee9988 commented 3 years ago

What are your extension settings?

maxresnikoff commented 3 years ago

I Have reverted to 2.5.12 and works fine again.

Here are my settings: "MinifyAll.disableHtml": true, "MinifyAll.disableJson": true, "MinifyAll.disableJsonc": true, "MinifyAll.disableLess": true, "MinifyAll.disablePhp": true, "MinifyAll.disableSass": true, "MinifyAll.disableScss": true, "MinifyAll.PrefixOfNewMinifiedFiles": ".min", "MinifyAll.openMinifiedDocument": false, "MinifyAll.minifyOnSaveToNewFile": true, "MinifyAll.minifyOnSave": true, "MinifyAll.terserMinifyOptions": {

    "mangle": true,
    "compress": {
        "drop_console": true,
        "dead_code": false,
        "keep_fnames": false,
        "keep_classnames": false
    }
}

I turned on minifyOnSave just to test if it was minifying at all.

Josee9988 commented 3 years ago

If you switch back to 2.5.20 will it minify again or give any output error? Does any of all the commands work?

maxresnikoff commented 3 years ago

So i reverted back to 2.5.13 and that didn't work either. Nothing was minifying at all Reverted again back to 2.5.12 and all working perfectly.

On v2.5.13 & 2.5.14, no error messages were shown. It just wouldn't minify.

For me: V2.5.12 - Works V2.5.13 - Doesn't work V2.5.14 - Doesn't work

I don't see a v2.5.20 in the options

Josee9988 commented 3 years ago

The latest version is 2.5.20 you can check it here: https://marketplace.visualstudio.com/items?itemName=josee9988.minifyall

maxresnikoff commented 3 years ago

Very odd, as VS shows the latest as 2.5.14 and there is no newer version to install... Screenshot 2021-04-13 at 10 53 23

Turns out VScode wasnt updating.... will update and try to install 2.5.20

maxresnikoff commented 3 years ago

I can confirm it is working. Many apologies! my mistake with VScode not updating and hence not being compatible with v2.5.20

Josee9988 commented 3 years ago

Always stay up to date! πŸ˜„