search

Josee9988 / MinifyAll

A 𝗩𝗦𝗖𝗼𝗱𝗲 𝗺𝗢𝗻𝗢𝗳𝗢𝗲𝗿 for JS, JSON/C, CSS, and HTML, you will love its simplicity! 🌟 π˜Ύπ™€π™’π™₯π™§π™šπ™¨π™¨ and π™œπ™―π™žπ™₯ files and folders πŸ“¦ Reduce your bundle and file sizes with lightning speed ⚑
https://minifyall.jgracia.es/
GNU General Public License v3.0
71 stars 10 forks source link

Ignore files based on RegEx list #131

Open LeeCoder139 opened 2 years ago

LeeCoder139 commented 2 years ago

πŸš€ Feature Request

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

welcome[bot] commented 2 years ago

Thanks for opening your first issue in Josee9988/project-template! Be sure to follow the issue template and provide every bit of information to help the developers!

Josee9988 commented 2 years ago

The minifier only does minify files with the enabled extensions so it will never minify a .gitignore. But it might be a good idea to disable the minimisation via a file following a specific pattern.

LeeCoder139 commented 2 years ago

Hi Jose

The file I am most concerned about is the workspace file. It is definitely being minified. I have the minify on save setting enabled. This file is a JSON file but it has no extension. Below is a screenshot of the file opened in VSCode

[image: image.png]

Kind regards Lee

On Tue, 12 Oct 2021, 18:27 Jose Gracia Berenguer, @.***> wrote:

The minifier only does minify files with the enabled extensions so it will never minify a .gitignore. But it might be a good idea to disable the minimisation via a file following a specific pattern.

β€” You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Josee9988/MinifyAll/issues/131#issuecomment-940739842, or unsubscribe https://github.com/notifications/unsubscribe-auth/APHLVKVBJ7BGJYHP6WZIS3DUGPPNZANCNFSM5FZEIKQA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Cube707 commented 2 years ago

A .workspace file is of the file type "JSON with comments", represented by jsonc in the settings. Disabling that will turn off the minifier on that file type while still minifying normal JSON files. That is probably sufficient as a quick workaround.

@Josee9988 I would recommend making the option description more clear.

From my point of view this should be sufficient and the use cases where there are actually collisions between files that are minified regularly and files that should not be minified are very rare. Most of the time the files are edited so rarely that disabling minify temporarily is absolutely fine.

If @LeeCoder139 is fine with the correct option and can continue working, I would note this problem and wait if more issues about collisions come up and if that is the case a pattern ignore option can be implemented. Maybe create a todo or milestone?

LeeCoder139 commented 2 years ago

Hi Jose

Ok I didn't know that. I was wondering what jsonc was. I will try it tomorrow.

Thanks

On Tue, 12 Oct 2021, 20:03 Cube, @.***> wrote:

A .workspace file is of the filetype "JSON with comments", represented by jsonc in the settings. Disabling that will turn off the minifier on that filetype while still minifying normal json files. That is probably sufficent as a quick workaround.

@Josee9988 https://github.com/Josee9988 I would recomend making the option description more clear.

From my point of view this should be sufficent and the usecases where there are acually colisions between files thate are minified regularly and files that should not be minified are very rare. Most of the time the files are eddited so rarly that disabling minify temporarylie is absoloutly fine.

If @LeeCoder139 https://github.com/LeeCoder139 is fine with the corrcet option and can continue working, I would note this problem and wait if more issues about collisions come up and if that is the case a pattern ignore option can be implemented. Maybe create a todo or milestone?

β€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Josee9988/MinifyAll/issues/131#issuecomment-940813369, or unsubscribe https://github.com/notifications/unsubscribe-auth/APHLVKQ7LXSAUMSQJJWKQLLUGP2XTANCNFSM5FZEIKQA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

LeeCoder139 commented 2 years ago

Hi Jose

Your suggestion worked. So I am all good. I still think it is a good idea to exclude by pattern but of course it is up to you if you want that feature.

Thanks for your help

Kind regards Lea Johnson JiffyTek

On Fri, 22 Oct 2021 at 01:07, Jose Gracia Berenguer < @.***> wrote:

@LeeCoder139 https://github.com/LeeCoder139 anything?

Is this issue still relevant?

β€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Josee9988/MinifyAll/issues/131#issuecomment-948654358, or unsubscribe https://github.com/notifications/unsubscribe-auth/APHLVKX4PJY25NHIIXRFJJLUIANC7ANCNFSM5FZEIKQA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Josee9988 commented 2 years ago

Perfect, I will still maintain this issue open and fix it

Cube707 commented 2 years ago

One thout I just had on this matter and wanted to document:

Implementing the regex ignroe would also allow useres to ignore specific filetypes ("ignore": "**/*.css" for example). Therefor the question: Should this feature make the existing Disable specific lanuage options depricated? It would probably be more performant and keep the config interface more consistent an clutter free.