Josee9988 / MinifyAll

A 𝗩𝗦𝗖𝗼𝗱𝗲 𝗺𝗢𝗻𝗢𝗳𝗢𝗲𝗿 for JS, JSON/C, CSS, and HTML, you will love its simplicity! 🌟 π˜Ύπ™€π™’π™₯π™§π™šπ™¨π™¨ and π™œπ™―π™žπ™₯ files and folders πŸ“¦ Reduce your bundle and file sizes with lightning speed ⚑
https://minifyall.jgracia.es/
GNU General Public License v3.0
71 stars 10 forks source link

Realtime config updates #134

Closed Cube707 closed 2 years ago

Cube707 commented 2 years ago

Realtime config updates

this PR implements a new feature, as discussed in #132

Description

A eventhandler is now atatched to the onDidChangeConfiguration, allowing for silent internal updating of most configurations.

Some special configs still need a window reload, so the user will be promted for it.

Additional context

to simplify the updating process (and the code in generall) I removed two globel variables that just stored some parts of the settings. Now the settings interface is used directly.

Josee9988 commented 2 years ago

Check that DeepScan error. Seems like MinifyOptions is not used. Have you modified anything that caused this error? I'll check it in a bit anyways Thanks as always @Cube707

Cube707 commented 2 years ago

Yes, I removed that and will also remove the import if thats ok with you.

I removed it to make the update process simpler (not copying the terserminifyoptions to a second variable but using the settings.terseroptions directly)

Josee9988 commented 2 years ago

Seems like everything works as expected. I'll merge it, fix some minor linter problems and release a new version